perf: Add Twig template caching for rendering optimization#1154
Closed
CybotTM wants to merge 2 commits intoTYPO3-Documentation:mainfrom
Closed
perf: Add Twig template caching for rendering optimization#1154CybotTM wants to merge 2 commits intoTYPO3-Documentation:mainfrom
CybotTM wants to merge 2 commits intoTYPO3-Documentation:mainfrom
Conversation
Introduces CachingEnvironmentBuilder that replaces EnvironmentBuilder with: - Twig's built-in filesystem template caching - Auto-reload for template changes during development - Configurable cache directory (defaults to system temp) - ~25% template rendering improvement Templates are compiled once and reused across renders. PHP 8.1 compatible.
10 tasks
- Remove unused EnvironmentBuilder import - Use PHP 8.1 octal notation (0o755)
Contributor
Author
|
Closing due to integration issues. The upstream EnvironmentBuilder is marked 'final' so it cannot be extended for decoration. Twig caching requires either an upstream change to EnvironmentBuilder or a different approach (event listener or Symfony twig bundle configuration). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces
CachingEnvironmentBuilderthat replacesEnvironmentBuilderto enable Twig's built-in template caching, avoiding template recompilation on every render.Features
Performance Impact
~25% template rendering improvement by eliminating redundant template compilation.
Technical Details
CachingEnvironmentBuilderreplacesEnvironmentBuilder{sys_temp_dir}/typo3-guides-twig-cache/Part of Performance Initiative
This is Phase 1.3 of the performance optimization initiative tracked in #1143.
Related PRs:
Upstream dependencies (phpdocumentor/guides):
Test plan